Add optional peer dependency in @parcel/rust #10101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Add missing dependencies
napi-wasm
for@parcel/rust
which is used inpackages/core/rust/browser.js
parcel/packages/core/rust/browser.js
Line 1 in 6f68c78
Previously
napi-wasm
was put indevDependencies
, this PR moves it todependencies
💻 Examples
The original issue is that when I try to bundle
@parcel/fs
in a browser environment like parcel repl did, it says "Could not resolve napi-wasm" sincenapi-wasm
is only declared indevDependencies
🚨 Test instructions
✔️ PR Todo