feat(webextension): add support for options_page manifest key#10267
Open
njg7194 wants to merge 1 commit intoparcel-bundler:v2from
Open
feat(webextension): add support for options_page manifest key#10267njg7194 wants to merge 1 commit intoparcel-bundler:v2from
options_page manifest key#10267njg7194 wants to merge 1 commit intoparcel-bundler:v2from
Conversation
This adds support for the `options_page` manifest key in web extensions. - Add `options_page` to the schema as a string field - Add dependency resolution for `options_page` in the transformer Although MDN marks `options_page` as deprecated, it is still widely supported: - Chrome actively supports it (not marked deprecated in Chrome docs) - Firefox added support in Firefox 113 (bugzilla.mozilla.org/1816960) The `options_page` key is equivalent to `options_ui.page` and provides a simpler way to specify an options page without additional configuration. Closes parcel-bundler#10076
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
options_pagemanifest key in web extensions.Changes
options_pageto the schema as a string field inschema.jsoptions_pageinWebExtensionTransformer.jsBackground
Although MDN marks
options_pageas deprecated, it is still widely supported:The
options_pagekey is equivalent tooptions_ui.pageand provides a simpler way to specify an options page without additional configuration likeopen_in_tab.Testing
Tested with a minimal manifest:
{ "name": "Test Extension", "version": "1.0.0", "manifest_version": 3, "options_page": "options.html" }Closes #10076