Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace registry.npmjs.cf with official registry.npmjs.org #9526

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Feb 12, 2024

↪️ Pull Request

The PR changes repl's SimplePackageInstaller, replacing the npmjs.cf with npmjs.org.

💻 Examples

npmjs.cf is deprecated (npmjs-cf/meta#8), while the npm official registry registry.npmjs.org has enabled CORS since 2022 (see npm/feedback#117 (comment)).

CodeSandbox has also approved on replacing npmjs.cf with npmjs.org: codesandbox/codesandbox-client#7939

🚨 Test instructions

Maybe just boot up a repl from my branch and see if it just works?

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic
Copy link
Member

That code is actually unused, the REPL uses this function:

options: {npmRegistryServer: 'registry.npmjs.org'},

@mischnic mischnic merged commit 8135749 into parcel-bundler:v2 Mar 1, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants