Add repl deploy to release workflow #9548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
reviewed
Feb 27, 2024
mischnic
reviewed
Feb 27, 2024
Co-authored-by: Niklas Mischkulnig <[email protected]>
mischnic
approved these changes
Feb 27, 2024
.github/workflows/tag-release.yml
Outdated
| repl_build: | ||
| name: Build REPL | ||
| runs-on: ubuntu-latest | ||
| needs: [unit_tests] |
There was a problem hiding this comment.
Will this work cross-workflow?
| @@ -216,3 +216,75 @@ jobs: | |||
| env: | |||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
| - run: yarn release | |||
|
|
|||
| # Deployment steps taken from https://github.com/colinwilson/static-site-to-vercel/blob/master/.github/workflows/deploy-preview.yml | |||
| repl_build: | |||
There was a problem hiding this comment.
How come this isn't in the nightly workflow as well?
There was a problem hiding this comment.
probably don't want to deploy to production on every nightly, just when we do stable releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from the ci workflow but using
--prodinstead of a PR alias domain