Update CI caching #9552
Merged
Update CI caching #9552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaOlejniczak
requested review from
devongovett,
marcins,
JakeLane,
mattcompiles,
alshdavid and
Nikola-3
MonicaOlejniczak
force-pushed
the
molejniczak/ci-cache
branch
from
0ef6a92 to
5eb4207
Compare
MonicaOlejniczak
force-pushed
the
molejniczak/ci-cache
branch
from
5eb4207 to
d31ddb9
Compare
marcins
approved these changes
Feb 29, 2024
| @@ -79,29 +80,30 @@ jobs: | |||
| packages/core/rust/*.node | |||
|
|
|||
| integration_tests: | |||
| name: Integration tests (${{matrix.os}}, Node ${{matrix.node}}) | |||
| name: Integration tests (${{ matrix.os }}, Node ${{ matrix.node }}) | |||
There was a problem hiding this comment.
Are these whitespace changes just some auto-formatting somewhere?
There was a problem hiding this comment.
Not auto-formatting, it was done manually and matches other workflow files. It's the style the Github documentation uses everywhere.
.github/workflows/ci.yml
Outdated
| strategy: | ||
| matrix: | ||
| node: [18, 20] | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| # These tend to be quite flakey, so one failed instance shouldn't stop | ||
| # others from potentially succeeding | ||
| fail-fast: false | ||
| runs-on: ${{matrix.os}} | ||
| runs-on: ${{ matrix.os}} |
There was a problem hiding this comment.
/nit this whitespace change seems inconsistent - no trailing space.
There was a problem hiding this comment.
.. related, maybe we should have prettier run on these .yml files? I think that's just adding it to
Line 70 in 5d8d7f0
There was a problem hiding this comment.
Thanks, I missed this. Prettier doesn't seem to follow the style, and just keeps everything as is
MonicaOlejniczak
force-pushed
the
molejniczak/ci-cache
branch
from
d31ddb9 to
a519cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
These changes update the CI workflow Rust caching so that it can be better reused across jobs, halving the storage used from 1849MB → 920MB. The specific changes include:
components: rustfmtinstallation from test jobsshared-key— this overrides the default per job cache and is more effective since we are using the same set of OS + targets for both jobsnameat the top and using${{ }}over${{}}for expressionsrunner.osovermatrix.osas it is always available💻 Examples
Observe the CI workflow behaviour, given the following example:
v0-rust-ubuntu-latest-a554fcb7-c1764bc1v0-rust-macos-latest-4be4b021-c1764bc1v0-rust-windows-latest-569c1dff-c1764bc1Note: REPL fails here because it is tested on push not pull request, and windows has been consistently failing on main branch
🚨 Test instructions
Look at the CI step for this pull request, or otherwise test on your own branch by adding a push trigger