Add CLI support to set Feature Flag values #9554
Conversation
marcins
changed the base branch from
v2
to
mszczepanski/add-feature-flag-system
packages/core/parcel/src/cli.js
Outdated
| let [name, val] = value.split('='); | ||
| if (name in DEFAULT_FEATURE_FLAGS) { | ||
| let featureFlagValue; | ||
| console.log(typeof DEFAULT_FEATURE_FLAGS[name]); |
There was a problem hiding this comment.
Oops, accidentally left this in.. 🤦
packages/core/parcel/src/cli.js
Outdated
| @@ -103,6 +104,30 @@ const commonOptions = { | |||
| }, | |||
| [], | |||
| ], | |||
| '-F, --feature-flag <name=value>': [ | |||
There was a problem hiding this comment.
Nitpick: Honestly prefer without the -F shorthand. People aren't going to type this by hand anyway so explicit is better.
There was a problem hiding this comment.
Also can you set multiple flags?
There was a problem hiding this comment.
I think it might need to be --feature-flag <name=value...> as per this?
But the input would be like parcel build --feature-flag foo=true bar=false whereas I normally prefer parcel build --feature-flag foo=true --feature-flag bar=false but not sure how easy that would be
There was a problem hiding this comment.
The latter is what works out the box with commander (i.e. parcel build --feature-flag foo=true --feature-flag bar=false), that was my intention rather than being able to set multiple flags with one option (I would expect most of time time it'll be some sort of launcher script configuring these anyway, and if you're setting a flag by hand it's usually a single one.
marcins
force-pushed
the
mszczepanski/feature-flags-cli
branch
from
a21fe91 to
ac4f8f1
Compare
↪️ Pull Request
Follows up on #9551 and adds support to the CLI to pass
featureFlagsintoInitialParcelOptions.The approach to this is a single
-For--feature-flagflag that takes aname=valueargument. Validation is done to ensure the name is a valid feature flag, andvaluematches the expected type - at the moment this is eitherstringorboolean, though I'd expectbooleanto be the most common.💻 Examples
parcel build --feature-flag makeItFaster=true src/index.js🚨 Test instructions
Manually tested to ensure that validation and setting the arguments in
InitialParcelOptionsworks as expected.✔️ PR Todo