Skip to content

Conversation

@seadanda
Copy link
Collaborator

@seadanda seadanda commented Aug 7, 2025

Started on top of #154 and some of those commits remain to avoid force-pushing.

ggwpez and others added 14 commits August 7, 2025 16:27
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
install-monitor:
mkdir -p ./ahm-monitor/backend/data
cd ahm-monitor/backend \
&& npm install \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& instead of #!/usr/bin/env bash + set -e for brevity or why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& really mainly for staying in same dir, just runs each line of a recipe with working directory as the root. I.e. here cd changes directory from the root to ahm-monitor/backend, then the next line is run in the root:

test:
    mkdir tmp
    cd tmp
    touch test

you'd end up with the behaviour of touch ./test, rather than the expected touch ./tmp/test

You can fix it with a shebang so it runs it all in the same instance, but I slightly prefer this as the recipes are then consistent, rather than throwing a shebang into some recipes but not others. don't feel too strongly about it though, happy to change if you think it's better style

@echo "just run-backend"
@echo "open https://migration.paritytech.io/?backend_url=http://localhost:3000"
# TODO @donal: Monitoring here
cd ahm-monitor/backend && yarn run start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn here vs npm above? will it cause issues?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn is enforced in the overall package.json, I found a way round it (it's basically just for tests) but forgot to revert this line

rm -f zombie-bite/doppelganger/{.crates.toml,.crates2.json}

# Clean up everything.
clean-harder: clean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah man, I would love this :)) the repo still generates so many things that should be git-ignored on each run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants