Add a test to validate all events during a whole staking era #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurpol
force-pushed
the
staking_era_check_events
branch
from
fd4fa68 to
262209d
Compare
Create a TS test validating all events occurring during a whole staking era, using 2 archive-mode databases (one for RC, one for AH) provided as input. The archive needs to accommodate at least an era and must be taken at the end of a given era to allow to inspect all events occurred during it.
sigurpol
force-pushed
the
staking_era_check_events
branch
from
262209d to
dfbcb12
Compare
x3c41a
reviewed
Oct 20, 2025
Comment on lines
+18
to
+24
| * - pre_check (rc_api_before, ah_api_before): | ||
| * APIs loaded from archive snapshots at era end | ||
| * Finds the start of era X by searching backwards through the archive | ||
| * | ||
| * - post_check (rc_api_after, ah_api_after): | ||
| * Same APIs (still era end snapshots) | ||
| * Validates events from era start to era end |
There was a problem hiding this comment.
I think it's a bit confusing - pre and post checks don't serve it's purpose. We can extract this test into a separate category, like post-AHM staking test.
I'll take care of the structure, calls and jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a TS test validating all events occurring during a whole staking era, using 2 archive-mode databases (one for RC, one for AH) provided as input.
The archive needs to accommodate at least an era and must be taken at the end of a given era to allow to inspect all events occurred during it.