Skip to content

notification: Fix memory leak of pending substreams #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2024
Merged

notification: Fix memory leak of pending substreams #296

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7683f90
notification: Fix memory leak of pending substreams
lexnv Dec 2, 2024
a756ebf
notification: Update comments
lexnv Dec 3, 2024
bf8e695
notification: Fix leak at the beginning of the method
lexnv Dec 3, 2024
c731f19
Merge branch 'master' into lexnv/pending-outbound-fix
lexnv Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/protocol/notification/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ pub(crate) struct NotificationProtocol {
/// Connected peers.
peers: HashMap<PeerId, PeerContext>,

/// Pending outboudn substreams.
/// Pending outbound substreams.
pending_outbound: HashMap<SubstreamId, PeerId>,

/// Handshaking service which reads and writes the handshakes to inbound
Expand Down Expand Up @@ -384,6 +384,8 @@ impl NotificationProtocol {
async fn on_connection_closed(&mut self, peer: PeerId) -> crate::Result<()> {
tracing::trace!(target: LOG_TARGET, ?peer, protocol = %self.protocol, "connection closed");

self.pending_outbound.retain(|_, p| p != &peer);

let Some(context) = self.peers.remove(&peer) else {
tracing::error!(
target: LOG_TARGET,
Expand Down
Loading