core: Register protocols at runtime #400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
dmitry-markin
approved these changes
Jun 5, 2025
| /// Bandwidth sink. | ||
| bandwidth_sink: BandwidthSink, | ||
|
|
||
| /// The keep-alive timeout for protocols. |
There was a problem hiding this comment.
Suggested change
| /// The keep-alive timeout for protocols. | |
| /// The executor & keep-alive timeout for protocols. |
| keep_alive_timeout: std::time::Duration, | ||
|
|
||
| /// Executor used to run protocols. | ||
| executor: Arc<dyn crate::executor::Executor>, |
There was a problem hiding this comment.
nit: IMO executor deserves a dedicated field in Litep2p, and may be we don't need a new struct then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to register notification protocols and request-response protocols at runtime.
This is beneficial for users who don't have the full set of protocols during the node initialization. Instead, the protocols will be known at runtime, potentially after calling into the substrate runtime itself.
The counterpart on the substrate side must take into account that each protocol instance has a channel of communication with the rest of the protocols. This might complicate things on the substrate side, but in theory, it's possible to pass a new channel.