-
Notifications
You must be signed in to change notification settings - Fork 23
webrtc: update str0m, fix multistream message decoding and encoding #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
remaining = &tail[len..]; | ||
if remaining.len() == 0 { | ||
// During negotiation the remote may not append a trailing newline. | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this observed with smoldot integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was observed when testing against the libp2p native WebRTC transport. During negotiation, the libp2p native WebRTC transport doesn't append an extra newline.
} | ||
|
||
// For the `Message::Protocols` to be interpreted correctly, it must be followed by a newline. | ||
header.push(b'\n'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could reach out to https://github.com/smol-dot/smoldot to align on the spec, then we could remove/simplify these functions.
We have diverged a bit from the spec, I wonder if this may break things down the line. Would the next message be interpreted correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have @freddyli7 working on utilizing smoldot as a client to test against the libp2p server, as well as the litep2p server. We plan on getting it into litep2p-perf
to run the performance behaviour. If things are incorrect in smoldot, we will create PRs upstream to fix them.
@timwu20 I released 0.11.1 |
22cec2e
to
fd8790f
Compare
…cation, modify multistream protocol message, modify opening based on str0m api changes
e4835d0
to
c97bc5d
Compare
Added 8cf27e9 which calls With this change I'm able to get |
Changes
Event::ChannelBufferedAmountLow
to close a substream/rtc channel.