Skip to content

Add x-shadow feature for Shadow simulation compatibility #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add x-shadow feature for Shadow simulation compatibility #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e26142f
fix: reuseaddr error under shadow
xDimon Oct 13, 2025
9f6780e
Merge branch 'master' into shadow-no-reuse
xDimon Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ quic = ["dep:webpki", "dep:quinn", "dep:rustls", "dep:ring", "dep:rcgen"]
webrtc = ["dep:str0m"]
rsa = ["dep:ring"]

# Shadow simulation compatibility
x-shadow = []

[profile.release]
debug = true

Expand Down
1 change: 1 addition & 0 deletions src/transport/tcp/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ impl TcpTransport {
socket.set_nonblocking(true)?;
socket.set_nodelay(nodelay)?;

#[cfg(not(feature = "x-shadow"))]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an existing runtime configuration for this in tcp::Config (and similarly for websocket):

litep2p/src/transport/tcp/config.rs

Line 42 in 8a02398

pub reuse_port: bool,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration only applies to listening sockets, and it is ok. But problem happens when we are trying to bind address for outgoing sockets.

match dial_addresses.local_dial_address(&remote_address.ip()) {
Ok(Some(dial_address)) => {
socket.set_reuse_address(true)?;
Expand Down
1 change: 1 addition & 0 deletions src/transport/websocket/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ impl WebSocketTransport {
socket.set_nonblocking(true)?;
socket.set_nodelay(nodelay)?;

#[cfg(not(feature = "x-shadow"))]
match dial_addresses.local_dial_address(&remote_address.ip()) {
Ok(Some(dial_address)) => {
socket.set_reuse_address(true)?;
Expand Down