webrtc: Avoid future being dropped when channel is full #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
haikoschol
commented
Nov 25, 2025
The loop is unconditionally exited after one iteration and therefore pointless.
This comment was marked as outdated.
This comment was marked as outdated.
lexnv
reviewed
Dec 5, 2025
lexnv
reviewed
Dec 5, 2025
lexnv
reviewed
Dec 8, 2025
and fix doc comments on SubstreamHandle
lexnv
reviewed
Dec 8, 2025
dmitry-markin
approved these changes
Dec 15, 2025
lexnv
reviewed
Dec 15, 2025
Collaborator
|
@haikoschol Can you merge master please? As you didn't allow maintainers to push changes, I can't do it and can't merge the PR as a consequence. |
Contributor
Author
done
Wanted to fix this but it turns out that's tricky when the PR comes from a fork in an org account. |
Collaborator
|
Nice job here everyone! Good to have this merged 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of #477. Specifically the issue described in this comment.