Enable parachain AD on AH, PC and YAP#12489
Open
sandreim wants to merge 80 commits into
Open
Conversation
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
# Conflicts: # .github/zombienet-tests/zombienet_cumulus_tests.yml
…t-sdk into sandreim/parachain-ad
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
# Conflicts: # .github/zombienet-tests/zombienet_cumulus_tests.yml # Cargo.lock # cumulus/zombienet/zombienet-sdk/Cargo.toml
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…t-sdk into sandreim/parachain-ad
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…t-sdk into sandreim/parachain-ad
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
sandreim
added
T4-runtime_API
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Contributor
Author
|
/cmd fmt |
…ytech/polkadot-sdk into sandrem/enable-AD-on-system-chains
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Contributor
Author
|
/cmd fmt |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
…rem/enable-AD-on-system-chains
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
bkchr
reviewed
Jun 30, 2026
Comment on lines
+74
to
+79
| /// Derive an [`sp_authority_discovery::AuthorityId`] from an [`AuraId`] by reusing the | ||
| /// underlying sr25519 public key bytes. Used in genesis config presets so collators can | ||
| /// reuse their Aura keystore secret for authority-discovery until they rotate. | ||
| pub fn authority_discovery_id_from_aura(aura: AuraId) -> sp_authority_discovery::AuthorityId { | ||
| sp_core::sr25519::Public::from(aura).into() | ||
| } |
Member
There was a problem hiding this comment.
I don't get why we need this function at all? Because you change the genesis code to also generate a key for authority discovery?
Contributor
Author
There was a problem hiding this comment.
Yes, this is only done for genesis.
bkchr
reviewed
Jun 30, 2026
bkchr
reviewed
Jun 30, 2026
bkchr
reviewed
Jun 30, 2026
Comment on lines
+96
to
+98
| let aura_raw: [u8; 32] = sp_core::sr25519::Public::from(aura.clone()).0; | ||
| let hash = sp_io::hashing::blake2_256(&aura_raw); | ||
| sp_core::sr25519::Public::from_raw(hash).into() |
Member
There was a problem hiding this comment.
Suggested change
| let aura_raw: [u8; 32] = sp_core::sr25519::Public::from(aura.clone()).0; | |
| let hash = sp_io::hashing::blake2_256(&aura_raw); | |
| sp_core::sr25519::Public::from_raw(hash).into() | |
| sp_core::sr25519::Public::from_raw([0; 32]).into() |
Contributor
Author
There was a problem hiding this comment.
This is what I initially wanted to do, but then decided not to because the all-zero 32 bytes is the canonical encoding of the Ristretto identity, and I also checked and schnorrkel accepts it as a valid pubkey. As far as I can tell tehre is nothing on the node side that filters it out, so attackers can forge and basically publish bogus addresses that other collators resolve.
If we change to zero here, we need to change the AD worker to ignore it.
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Authority Discovery support for test Parachains.
TODO: