Improve Now Playing Screen Gestures and Album Art Layout - #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
As discussed in #93 + #95, on big screens, swiping down on the header to close the Now Playing screen is awkward. Now you can swipe down on the album art or background instead.
Also, the album art used to sit at the very top, leaving a lot of empty space on tall or wide screens. Now it’s nicely centered (vertically in portrait, horizontally in landscape), and the glow background picks up a vibrant color from the album art for a cleaner, more immersive look. Smooth transitions make it feel extra polished.
What’s changed
Test APK:
DSub2000_5.6.3-google-debug.apk.zip