Skip to content

Set Navigation bar to black on dark themes - #108

Merged
paroj merged 1 commit into
paroj:edgefrom
qduff:edge
Jan 23, 2026
Merged

Set Navigation bar to black on dark themes#108
paroj merged 1 commit into
paroj:edgefrom
qduff:edge

Conversation

@qduff

@qduff qduff commented Jan 19, 2026

Copy link
Copy Markdown

Uses the android:statusBarColor property to make the navigation bar black on dark themes. Without this it's white, at least on my phone.

Before:
Screenshot_20260119_185123_github daneren2005 dsub_edit_218228775013054

After:
Screenshot_20260119_183418_github paroj dsub2000_edit_218236546554198

Also:

  • Downgrades the minSdkVersion to 21 as there is I nothing that needs a greater version (I think!)
  • Merges the values-v21/themes.xml into the normal themes.xml given minSdkVersion is equal to it.

Thanks :)

@paroj

paroj commented Jan 22, 2026

Copy link
Copy Markdown
Owner

minSdk was at 24 because of some link errors: ac22ada

however CI passes. Will verify it locally later, but it seems to work now.

@qduff

qduff commented Jan 23, 2026

Copy link
Copy Markdown
Author

Hmm I think you're right - I've taken another look and this fork has a few uses the Java stream API, which is only supported in Java 8 (API level 24 onwards). I assume this would cause crashes on older devices.

I'll be honest I'm not that familiar with Android development, and I'll test it myself later to confirm, but I think you can also get around this with https://developer.android.com/studio/write/java8-support - though it might not even be worth supporting these old devices.

IMO the dark navigation bar commit is still worthwhile, and If you prefer I can remove the other commit in the meantime.

Thanks

@paroj

paroj commented Jan 23, 2026

Copy link
Copy Markdown
Owner

yes, please drop the minSdk change for now then

@paroj
paroj merged commit 53d6882 into paroj:edge Jan 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants