Set Navigation bar to black on dark themes - #108
Conversation
|
minSdk was at 24 because of some link errors: ac22ada however CI passes. Will verify it locally later, but it seems to work now. |
|
Hmm I think you're right - I've taken another look and this fork has a few uses the Java stream API, which is only supported in Java 8 (API level 24 onwards). I assume this would cause crashes on older devices. I'll be honest I'm not that familiar with Android development, and I'll test it myself later to confirm, but I think you can also get around this with https://developer.android.com/studio/write/java8-support - though it might not even be worth supporting these old devices. IMO the dark navigation bar commit is still worthwhile, and If you prefer I can remove the other commit in the meantime. Thanks |
|
yes, please drop the minSdk change for now then |
Uses the
android:statusBarColorproperty to make the navigation bar black on dark themes. Without this it's white, at least on my phone.Before:

After:

Also:
minSdkVersionto 21 as there is I nothing that needs a greater version (I think!)minSdkVersionis equal to it.Thanks :)