feat: Add idempotency feature to detect duplicate requests due to network conditions#1208
Closed
abubkr-hago wants to merge 3 commits intoparse-community:masterfrom
abubkr-hago:idempotent-requests
Closed
feat: Add idempotency feature to detect duplicate requests due to network conditions#1208abubkr-hago wants to merge 3 commits intoparse-community:masterfrom abubkr-hago:idempotent-requests
abubkr-hago wants to merge 3 commits intoparse-community:masterfrom
abubkr-hago:idempotent-requests
Conversation
Thanks for opening this pull request!
|
mtrezza
reviewed
Oct 5, 2024
Member
There was a problem hiding this comment.
It seems that this always adds the req ID header to all requests. This should be optional because if the feature is not in use it just causes more traffic costs. Compare other Parse client SDKs how this is implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
ParseObject saved multiple times on slow internet connection
Closes: #764
Approach
Add
X-Parse-Request-Idheader to requests allowing parse-server to handle idempotency.TODOs before merging