Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add more types to pass all type definition tests #2486

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 8, 2025

Pull Request

Issue

The type definitions are 98% compatible with definitelyTyped. After this PR we should be able to release types.
Note there are a lot of functions missing types and aren't included in the test suite. These can be added as issues arises.

Ref: #2012

Approach

  • Remove CI fail suppression
  • Add missing generic types
  • Add missing basic types
  • Refactor reusable types
  • Add missing tests

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Mar 8, 2025

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (539ba2a) to head (948eb14).
Report is 28 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2486   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6256      6259    +3     
  Branches      1474      1466    -8     
=========================================
+ Hits          6256      6259    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dplewis dplewis requested a review from a team March 8, 2025 08:22
@mtrezza mtrezza changed the title refactor: Pass all type definition tests refactor: Add more types to pass all type definition tests Mar 8, 2025
@mtrezza mtrezza merged commit e7d12ae into parse-community:alpha Mar 8, 2025
11 of 12 checks passed
@dplewis dplewis deleted the pass-type-tests branch March 9, 2025 17:38
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 10, 2025
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants