Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds Uint8Array support for Parse.File #2548

Open
wants to merge 5 commits into
base: alpha
Choose a base branch
from

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 1, 2025

Pull Request

Issue

Parse.File.encodeBase64 accepts both number[] and Uint8Array but there is no way to pass Uint8Array to Parse.File.

There is also a flaky test #2530. I believe it occurs because those files are so small in size they save before you get a chance to cancel which causes the timeout.

Closes: #2530

Approach

  • Add check for Uint8Arrays
  • Fix flaky test

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Apr 1, 2025

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c7015ba) to head (2d3a197).
Report is 8 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6238      6238           
  Branches      1464      1452   -12     
=========================================
  Hits          6238      6238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dplewis dplewis requested a review from a team April 1, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky test Parse Dist Test parse.js / parse.min.js can cancel save file with uri
1 participant