-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Remove husky
and prettier
in favor of eslint
#2550
Conversation
🚀 Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2550 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6238 6238
Branches 1452 1452
=========================================
Hits 6238 6238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removing husky? Now I like the sound of that! |
This is ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please take a look at the conflicts
@mtrezza Done! |
That would be nice for Parse Server as well! |
Yep that’s the plan |
Pull Request
Issue
Using husky adds significant time when committing code. Per commit can take up to 10 seconds of wait time.
Prettier formats the code which can managed by eslint.
Running prettier then eslint has errors which required
--fix
. This PR fixes those lint issues so prettier can be removed.Closes: #2251
Approach