Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Cloud Code triggers Parse.Cloud.beforeFind(Parse.File)and Parse.Cloud.afterFind(Parse.File) #8700

Merged
merged 8 commits into from
Mar 27, 2025

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jul 24, 2023

Pull Request

Issue

Currently, there are no find triggers for files.

Closes: #8241
Closes: #6572

Approach

Tasks

  • Add tests

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add beforeFind triggers for file feat: Add beforeFind triggers for file Jul 24, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 24, 2023

🚀 Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.12%. Comparing base (042a920) to head (46c930f).
Report is 2 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8700      +/-   ##
==========================================
+ Coverage   93.10%   93.12%   +0.01%     
==========================================
  Files         187      187              
  Lines       15016    15037      +21     
==========================================
+ Hits        13981    14003      +22     
+ Misses       1035     1034       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dblythy
Copy link
Member Author

dblythy commented Jul 27, 2023

Unfortunately, as browsers do not pass headers in when using an src tag, request.user won't be passed through. However, support for that feature seems to be extremely complicated and likely breaking.

So, I think this implementation is a good start.

@dblythy dblythy requested a review from a team March 19, 2025 10:28
Signed-off-by: Manuel <[email protected]>
@mtrezza mtrezza changed the title feat: Add beforeFind triggers for file feat: Add Cloud Code triggers Parse.Cloud.beforeFind(Parse.File)and Parse.Cloud.afterFind(Parse.File) Mar 27, 2025
@mtrezza
Copy link
Member

mtrezza commented Mar 27, 2025

Docs: parse-community/docs#960

@mtrezza mtrezza merged commit b2beaa8 into parse-community:alpha Mar 27, 2025
24 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 27, 2025
# [8.1.0-alpha.2](8.1.0-alpha.1...8.1.0-alpha.2) (2025-03-27)

### Features

* Add Cloud Code triggers `Parse.Cloud.beforeFind(Parse.File)`and `Parse.Cloud.afterFind(Parse.File)` ([#8700](#8700)) ([b2beaa8](b2beaa8))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.1.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict file download beforeGetFile trigger
3 participants