fix: Parse Server doesn't shutdown gracefully #9634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for opening this pull request! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #9634 +/- ##
==========================================
+ Coverage 93.12% 93.15% +0.03%
==========================================
Files 187 187
Lines 15037 15066 +29
==========================================
+ Hits 14003 14035 +32
+ Misses 1034 1031 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dplewis
force-pushed
the
graceful-shutdown
branch
from
89de779 to
1877ced
Compare
dplewis
commented
Mar 11, 2025
|
@parse-community/server-review This is ready for review. |
|
@mtrezza is this good to merge? |
|
I hade a review comment, but it was pending. |
mtrezza
reviewed
Mar 20, 2025
mtrezza
approved these changes
Mar 27, 2025
mtrezza
reviewed
Mar 27, 2025
mtrezza
changed the title
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 27, 2025
# [8.1.0-alpha.3](8.1.0-alpha.2...8.1.0-alpha.3) (2025-03-27) ### Bug Fixes * Parse Server doesn't shutdown gracefully ([#9634](#9634)) ([aed918d](aed918d))
|
🎉 This change has been released in version 8.1.0-alpha.3 |
parseplatformorg
pushed a commit
that referenced
this pull request
Apr 4, 2025
# [8.1.0](8.0.2...8.1.0) (2025-04-04) ### Bug Fixes * Parse Server doesn't shutdown gracefully ([#9634](#9634)) ([aed918d](aed918d)) ### Features * Add Cloud Code triggers `Parse.Cloud.beforeFind(Parse.File)`and `Parse.Cloud.afterFind(Parse.File)` ([#8700](#8700)) ([b2beaa8](b2beaa8)) * Add default ACL ([#8701](#8701)) ([12b5d78](12b5d78)) * Upgrade Parse JS SDK from 6.0.0 to 6.1.0 ([#9686](#9686)) ([f49c371](f49c371))
|
🎉 This change has been released in version 8.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
While working on parse-community/Parse-SDK-JS#2490 I noticed that
parseServer.handleShutdown()doesn't close all connections. This results inserver.close(callback)callback from running causing timeouts in the test suite.Approach
I moved all closing logic to
handleShutdown. I also added it to the test suite onreconfigureServer. This has a few benefits.helper.jsClient is closederror or something similar. This allows for invariant between testreconfigureServercallsTasks