Refactor subscription engine#848
Open
DavidBadura wants to merge 12 commits into
Open
Conversation
DavidBadura
commented
Apr 26, 2026
3929aca to
c7f4ba6
Compare
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
56fba2a to
f17c3f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SubscriptionEngineinterface has been changed.The methods
setup,boot,run,teardown,remove,reactivate,pauseandrefreshhave been replacedby a single
executemethod that takes a command object.The
idsandgroupsfilters, previously passed viaSubscriptionEngineCriteria,are now constructor parameters of the command objects.
The
SubscriptionEngineCriteriais now only used for thesubscriptionsmethod.before:
after:
Further changes:
CanRefreshSubscriptionsinterface has been removed. Refresh is now part of theSubscriptionEngineinterface via theRefreshcommand.ProcessedResultnow extendsResult, so theexecutemethod always returns aResult. TheBootandRuncommands return aProcessedResult.DefaultSubscriptionEngineaccepts an optionalEventDispatcherInterfaceas last constructor argument to hook into the engine with own listeners.