Remove catppuccin-gtk overlay workaround — nixpkgs pin now includes the upstream fixes#636
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the temporary nixpkgs overlay and associated patch files for catppuccin-gtk and catppuccin in modules/common/desktop.nix, as the upstream nixpkgs channel has now integrated these fixes. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned nixpkgs rev (
18b9261cb3294b6d2a06d03f96872827b8fe2698) now contains both upstream fixes that PR #618 was mirroring locally:455d916d0c—python3Packages.catppuccin: fix build with matplotlib 3.11+(Fix #129 (caused by matplotlib 3.11 deprecating mpl.style.core) catppuccin/python#130)894acc94f6—catppuccin-gtk: fix build with python314+Both commits verified as ancestors of the pinned revision. The local mirror added in #618 (the
nixpkgs.overlaysblock inmodules/common/desktop.nixplus the two verbatim patch files) is now redundant, so this PR removes it:nixpkgs.overlaysblock frommodules/common/desktop.nixmodules/common/patches/catppuccin-gtk-python-3.14.patchandmodules/common/patches/catppuccin-python-matplotlib-3.11.patchmodules/common/patches/directoryReferences: catppuccin/python#129 and catppuccin/python#130 (upstream issue/fix).
Verification
This cloud session cannot run
nix, so cosmo's CI (thebuild-nixosdry-run eval) is the verification gate for this PR. A full local build of the affected hosts should be confirmed via the machine's converge loop after merge.Once this merges, the routine that opened this PR can be deleted at https://claude.ai/code/routines.
Generated by Claude Code