-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to nx workspace #1483
base: dev
Are you sure you want to change the base?
Conversation
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
declare function require(moduleName: string): any; | ||
|
||
const findPartialsRE = /{{#?>\s*([\w-/.]+)(?:.|\s+)*?}}/g; |
Check failure
Code scanning / CodeQL
Inefficient regular expression
} | ||
|
||
findPartials(pattern: Pattern): RegExpMatchArray | null { | ||
const matches = pattern.template.match(findPartialsRE); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
} | ||
|
||
findPartial(partialString: string): string { | ||
const partial = partialString.replace(findPartialsRE, '$1'); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
} | ||
|
||
findPartials(pattern: Pattern): RegExpMatchArray | null { | ||
return pattern.template.match(this.findPartialsRE); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
Is removing |
I know what you want to imply by that, and it surely would improve our overall popularity. But I don't see any of us working on that feature and bring it to the point storybook did. Where you can simply add storybook to your workspace with one command and just include your component. |
Summary of changes:
@pattern-lab/types
package for common types over all packagesuikit-polyfills
,engine-react
,development-edition-engine-react
)development-edition-engine-twig-php
Open Points