Skip to content

fix(table): fix table accessibility issue-2813 #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(table): fix table accessibility issue-2813 #2885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f189ae
fix: fixed accessibility for pf-table
atharv-g-kulkarni Dec 5, 2024
0136786
Merge branch 'main' into pf-table-2813
atharv-g-kulkarni Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elements/pf-table/pf-th.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class PfTh extends LitElement {
const closestThead = this.closest('pf-thead');
const closestTable = this.closest('pf-table');
const isChildOfThead = !!closestThead && !!closestTable?.contains(closestThead);
const role = isChildOfThead ? 'colheader' : 'rowheader';
const role = isChildOfThead ? 'columnheader' : 'rowheader';
this.setAttribute('role', role);
}

Expand Down
1 change: 1 addition & 0 deletions elements/pf-table/pf-tr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export class PfTr extends LitElement {
<pf-button id="toggle-button"
aria-expanded=${String(this.expanded) as 'true' | 'false'}
plain
label="Expand Button"
@click=${this.#onClick}>
<pf-icon id="toggle-icon"
icon="angle-right"
Expand Down
Loading