feat(helper-text): add pf-helper-text element #2947
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dali327519294
changed the title
bennypowers
changed the title
bennypowers
requested changes
Oct 22, 2025
| iconSet: string | undefined; | ||
|
|
||
| /** | ||
| * מחשב את האייקון שיוצג, בהתבסס על הסטטוס או המאפיין icon |
Comment on lines
16
to
17
| * @slot icon - Custom icon to override default | ||
| * @slot - Place element content here |
There was a problem hiding this comment.
move these to the render template. see RedHat-UX/red-hat-design-system#2548 for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Created a new custom element using LitElement.
Implemented a status property with options: 'default', 'success', 'warning', 'error', 'indeterminate'.
Added support for custom icons via icon and icon-set properties.
Added a slot named "icon" for overriding the default icon with a custom SVG.
Added a default slot for the text content.
Styled the element so that the text and icon colors correspond to the status.
Testing Instructions
- Import the element in a demo page:
<script type="module"> import '@patternfly/elements/pf-icon/pf-icon.js'; import '@patternfly/elements/pf-helper-text/pf-helper-text.js'; </script>- Add elements with different statuses and icons:
Default helper text Warning helper text Success helper textThe text appears correctly.
The icon matches the status or the custom icon if provided.
The slot "icon" can be overridden with a custom SVG.
Notes to Reviewers