fix(DrawerPanelContent): add inert when drawer is closed #12027
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logonoff
force-pushed
the
11938-drawerpanelcontent
branch
from
ec1b119 to
7354e16
Compare
|
It looks like the drawerresize.spec.ts integration test is failing - would you mind taking a look? |
logonoff
force-pushed
the
11938-drawerpanelcontent
branch
from
7354e16 to
29aa1e5
Compare
logonoff
changed the title
logonoff
changed the title
|
Preview: https://pf-react-pr-12027.surge.sh A11y report: https://pf-react-pr-12027-a11y.surge.sh |
|
@mcoker, I've updated the PR to just add the It's unclear to me whether this will fix the issue I was having in OCP without running the end to end tests in an updated version of PatternFly. However, as you mentioned, we should have this attribute anyway so I think it's worth adding. We can close the linked issue upon merging, and I'll reopen the issue if the problem continues to happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11938
Have not tested this against OCP but this fixes the core issue where the drawer panel content still takes up width even when closed.
After this PR, the panel content is still "display"ed but now takes up width 0.
We cannot use
display: nonehere as that breaks the drawer opening animationAdditional issues: