Out of date domain list data (was: Version in gemspec wrong)#17
Open
jamiecobbett wants to merge 2 commits intopauldix:masterfrom
Open
Out of date domain list data (was: Version in gemspec wrong)#17jamiecobbett wants to merge 2 commits intopauldix:masterfrom
jamiecobbett wants to merge 2 commits intopauldix:masterfrom
Conversation
|
+1 for this - the domain list data being out of data is preventing correct parsing of top level domains like .do |
|
another +1 for this. we actually just ran into a similar issue with an out of date domain list. |
|
+1 — Can we get this pulled in, pretty please? |
|
+1 |
|
As a temporary workaround for supporting newer TLDs, you can use: d = Domainatrix::DomainParser.new("path/to/updated_effective_tld_names.dat")
d.parse("http://abc.do")
# => {:public_suffix=>"do", :domain=>"abc", :subdomain=>"", :scheme=>"http", :host=>"abc.do", :path=>"", :url=>"http://abc.do"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It says 0.0.9, but I think it should be 0.0.10.
This prevented me from fully using Bundler's git option.