chore: consolidate CI stages #1433
Conversation
|
It would be better to reuse jsbt actions https://github.com/paulmillr/noble-hashes/tree/main/.github/workflows there is test-js and test-ts, difference is in: one tests compiled js code, other raw ts. (We should prob use test-js) |
|
Makes sense Maybe let's merge this one for now and I'll take a look at moving it to jsbt in a follow up? It looks pretty straight forward so can probably have a look tomorrow |
|
The changes aren’t compatible — the next one would 100% replace the first one. So, doesn’t make sense to merge both. |
|
@paulmillr ok i've switched it deno fails on windows: we need a cross-platform way of conditionally installing it i guess. or just skip windows for that step prettier also fails on windows: this one is odd since the formatting seems to differ between windows and linux. line endings maybe? |
|
@43081j I see you’re doing matrix in matrix. This is unnecessary: let’s just leave jsbt matrix. This way deno would only be tested once. It could also fix prettier |
|
because we need to use windows, linux and mac here but jsbt only uses one OS at a time |
|
Hmmm that's my screwup; i've thought matrix in jsbt has windows and mac as well. Well... |
|
no worries, let me know if you want any help updating that i suppose we will still need to add a condition around the deno stuff |
|
this is all sorted now but the extra runs are showing up our known-to-be-flaky test would be nice to figure out why some of them are flaky sometimes we're not doing anything complex in some of the failures. make a file, wait for a spy. but the timeout is reached, which suggests the spy never reaches the amount of calls we expected |
|
so you are doing a matrix over matrix? this yields 78 ci jobs. seems incorrect. |
|
you're right! i forgot to remove the old matrix have done that now |
No description provided.