Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch fix #5

Merged
merged 5 commits into from
Jun 7, 2012
Merged

Watch fix #5

merged 5 commits into from
Jun 7, 2012

Conversation

dbashford
Copy link
Contributor

No description provided.

@@ -45,6 +45,7 @@ function FSWatcher(options) {
FSWatcher.prototype = Object.create(EventEmitter.prototype);

FSWatcher.prototype._getWatchedDir = function(directory) {
directory = directory.replace(/\/$/,"");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about win32?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, a space after comma and ''

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little clueless when it comes to windows. Is it just a matter of replacing both forward and back slashes? That's what you are referring to ya?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

paulmillr added a commit that referenced this pull request Jun 7, 2012
@paulmillr paulmillr merged commit 73c14ad into paulmillr:master Jun 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants