Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-9749 Add option to skip jdbc client info validation #7271

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kalinchan
Copy link
Member

Description

Add option to admin console to skip client info validation.
Also throw a restart required when changed.

Important Info

Blockers

n/a

Testing

New tests

none

Testing Performed

Deployed an simple jpa example from Payara-Examples to verify if client info was skipped when set.
Also verified behaviour isn't changed dynamically

Testing Environment

Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: /Users/kalinchan/Library/apache-maven-3.9.8
Java version: 21.0.5, vendor: Azul Systems, Inc., runtime: /Users/kalinchan/.sdkman/candidates/java/21.0.5-zulu/zulu-21.jdk/Contents/Home
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "15.1.1", arch: "aarch64", family: "mac"

Documentation

payara/Payara-Documentation#578

Notes for Reviewers

@kalinchan kalinchan requested a review from Pandrex247 April 2, 2025 11:55
@kalinchan kalinchan requested a review from Pandrex247 April 2, 2025 13:38
@Pandrex247
Copy link
Member

I'm also not yet convinced we need the config listener at all actually.
Properties are typically dynamic, not requiring a restart to apply, and eyeballing the init and close methods it's not obvious to me what could go wrong if the value changes.

None of the other JDBC settings request a restart either afaik

Need to give it some thought - maybe worth a test 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants