feat: enable customization of LivePreviewToggler and update related types #14518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmielulu
requested review from
AlessioGr,
JarrodMFlesch,
denolfe and
jacobsfletch
as code owners
chmielulu
force-pushed
the
feat/ability-to-customize-live-preview-toggler
branch
from
ae2e69e to
8158d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR restores the ability to customize the component responsible for toggling Live Preview.
Historically, Live Preview customization was possible through the
livePreviewtab. After that tab was removed and the functionality was replaced with theLivePreviewTogglerrendered insideDocumentControls, the extension point for customizing the Live Preview trigger was lost. As a result, developers could no longer override or replace the button that toggles Live Preview.This PR reintroduces that capability by allowing the
LivePreviewTogglercomponent to be fully customized.