This repository was archived by the owner on May 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Added nginx.conf to the package to avoid the need for a custom zip #6
Open
coreyperkins
wants to merge
54
commits into
pbolduc:master
Choose a base branch
from
agconnections:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Copy-Item command.
Owner
|
As you are adding DSx_v2 size VMs, please add the other sizes, from Standard_D1_v2 to at least Standard_D5_v2. Also, since many people will use the template to set up something for testing, please leave the default instance size at DS2 (DS2_v2 is fine since it is the same cost). I do not want to burn through my MSDN credits using a VM size bigger than necessary. If you fix the size of VMs, I will merge the pull request. Also, I would like to see things more configurable,
|
Owner
|
Sorry for the delay, I was on vacation (out of the country) for most of October. I was really busy before going on vacation and did not time to review your recent changes. I hope to get caught up this week and find time this weekend to get these changes merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.