fix in PC parser

[Yushan-Wang]

While doing other stuff, I noticed this "typo".
However, it doesn't result in any errors.
I don't think it's worth filling in the checks below.
Only the copyright date is updated.

List of things to check before making a PR

Before merging your code, please check the following:

• you have added a line describing your changes to the Changelog;
• you have added unit tests for any new or improved feature;
• In case you updated dependencies, you have checked pdi/docs/CheckList.md
• you have checked your code format:
  • you have checked that you respect all conventions specified in CONTRIBUTING.md;
  • you have checked that the indentation and formatting conforms to the .clang-format;
  • you have documented with doxygen any new or changed function / class;
• you have correctly updated the copyright headers:
  • your institution is in the copyright header of every file you (substantially) modified;
  • you have checked that the end-year of the copyright there is the current one;
• you have updated the AUTHORS file:
  • you have added yourself to the AUTHORS file;
  • if this is a new contribution, you have added it to the AUTHORS file;
• you have added everything to the user documentation:
  • any new CMake configuration option;
  • any change in the yaml config;
  • any change to the public or plugin API;
  • any other new or changed user-facing feature;
  • any change to the dependencies;
• you have correctly linked your MR to one or more issues:
  • your MR solves an identified issue;
  • your commit contain the Fix #issue keyword to autoclose the issue when merged.

[Yushan-Wang]

This is related to the CI, which breaks regularly.
Does this need a dedicated PR?

[jbigot]

Not necessarily for me, but is this directory always available. Shouldn't you then mount a tmpdir to ensure it's available?

[Yushan-Wang]

Not necessarily for me, but is this directory always available. Shouldn't you then mount a tmpdir to ensure it's available?

@JAuriac

[benoitmartin88]

I would not include this change.

[JAuriac]

This TEST_DIR is necessary for another ongoing PR, which includes a fix.
#543 (comment)

[Yushan-Wang]

OK. We will wait for the no-pdi PR first.
Anyway, if I exclude this change, the CI will not run, thus the PR can not be approved.

[jbigot]

So, what's the status, should this change remain in this PR?

[JAuriac]

This change will be overwritten by the no-pdi PR, where we use export CTEST_DIR="/tmp", so this change does not have to remain in this PR.

[jbigot]

good catch!

[jbigot]

Not necessarily for me, but is this directory always available. Shouldn't you then mount a tmpdir to ensure it's available?

[jbigot]

can we make a test that would catch this bug?

[Yushan-Wang]

can we make a test that would catch this bug?

I can try!

[jbigot]

Looks good, but the test logic is slightly above my level of understanding. I would love for you to guide me through it, and mybe add a few comments, so that we're not lost the next time we need to touch this.

[jbigot]

So, what's the status, should this change remain in this PR?

[jbigot]

Have you checked that the current writing of the test does indeed catch the bug if you don't fix the code?

[jbigot]

BTW, this is a bugfix and should be mentioned in the Changelog

[Yushan-Wang]

Have you checked that the current writing of the test does indeed catch the bug if you don't fix the code?

Yes, it does.