Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dep-logic for python specifier logic #2648

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 73.55372% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 84.72%. Comparing base (0275813) to head (6817503).
Report is 1 commits behind head on main.

Files Patch % Lines
src/pdm/models/specifiers.py 71.81% 18 Missing and 13 partials ⚠️
src/pdm/cli/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2648      +/-   ##
==========================================
- Coverage   84.79%   84.72%   -0.07%     
==========================================
  Files         104      104              
  Lines       10396    10277     -119     
  Branches     2275     2233      -42     
==========================================
- Hits         8815     8707     -108     
+ Misses       1106     1100       -6     
+ Partials      475      470       -5     
Flag Coverage Δ
unittests 84.50% <73.55%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit c456a78 into main Feb 23, 2024
19 of 21 checks passed
@frostming frostming deleted the refactor/specifier branch February 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant