Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidpi support #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

PegasisForever
Copy link
Contributor

  • Added a new setting to set scaling of the application.
  • Automatically scale font size.

@peerdavid
Copy link
Owner

Thanks for this great improvement! I will test your solution to hidpi soon and merge the PR afterward.

@peerdavid
Copy link
Owner

I tested this PR but I have some problems: I changed the resolution to 100% and then nothing is shown in the File Explorer and also not in the Settings. So I can not change it back. Also, the text looks relatively small in the default of 75% on my machine when I start RemaPy the first time. I use a display with a resolution of 1920 x 1080.

@peerdavid peerdavid added question Further information is requested and removed question Further information is requested labels Dec 8, 2020
@PegasisForever
Copy link
Contributor Author

PegasisForever commented Dec 14, 2020

I changed the resolution to 100% and then nothing is shown in the File Explorer and also not in the Settings.

Strange, it works fine on my machine, can you check what value of scaling got saved to the ~/.remapy/config file?

Also, the text looks relatively small in the default of 75% on my machine

The default scaling came from window.tk.call('tk', 'scaling'), which to my understanding, doesn't respect dpi settings of the system and returns screen physical dpi / 72. I changed it so it defaults to 100% now.

@sabrekke
Copy link

sabrekke commented May 19, 2021

I'm using RemaPy on a Hidpi display, and just changed the parameters in rema.py manually to increase the row and icon size. This worked well for a few weeks, then suddenly today the file explorer failed to render as described by peerdavid. The settings worked as normal, as I had not made any changes there.

Not sure if this is of any help at all, but at least I encountered the same issues independently of this pull request.

Edit: This was an unrelated problem. I currently just set row_height = 70 in rema.py, and that works well enough for a hidpi display until another solution is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants