Conversation
4003ca2 to
85238c8
Compare
85238c8 to
85cbfda
Compare
orangejulius
left a comment
There was a problem hiding this comment.
Awesome, this will help all of us on ARM machines :)
I left some minor comments regarding the Github Actions files, I'd really like to keep them consistent.
| matrix: | ||
| os: | ||
| - ubuntu-22.04 | ||
| - ubuntu-22.04-arm |
There was a problem hiding this comment.
Nice, should we test on ARM everywhere? It's always nice to keep things consistent and who knows where other ARM bugs could be lurking.
| - ubuntu-24.04 | ||
| - ubuntu-24.04-arm |
There was a problem hiding this comment.
Similarly, for consistency, let's hold off on adding Ubuntu 24 in this PR, we can add it everywhere as part of testing and rolling out pelias/docker-baseimage#32.
It's much much easier to do Node.js and Ubuntu version upgrades if our github actions files are consistent. Updating them all en masse can be easily done with scripting if they're identical, but then every difference creates extra work.
This PR adds tests for ARM architecture instances.
Some of the floating-point math values differ between architectures, notably:
Note: this PR also makes it possible to develop on an ARM machine, without it the tests fail.