Skip to content

Testing for ARM architecture#117

Draft
missinglink wants to merge 1 commit intomasterfrom
ci-multiple-os-arch
Draft

Testing for ARM architecture#117
missinglink wants to merge 1 commit intomasterfrom
ci-multiple-os-arch

Conversation

@missinglink
Copy link
Copy Markdown
Member

@missinglink missinglink commented Sep 4, 2025

This PR adds tests for ARM architecture instances.

Some of the floating-point math values differ between architectures, notably:

  • negative zero in some cases rather than positive zero
  • some floats differ by small values less than 1e-6 (0.000001)

Note: this PR also makes it possible to develop on an ARM machine, without it the tests fail.

@missinglink missinglink force-pushed the ci-multiple-os-arch branch 2 times, most recently from 4003ca2 to 85238c8 Compare September 4, 2025 13:12
Copy link
Copy Markdown
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this will help all of us on ARM machines :)

I left some minor comments regarding the Github Actions files, I'd really like to keep them consistent.

matrix:
os:
- ubuntu-22.04
- ubuntu-22.04-arm
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, should we test on ARM everywhere? It's always nice to keep things consistent and who knows where other ARM bugs could be lurking.

Comment on lines +11 to +12
- ubuntu-24.04
- ubuntu-24.04-arm
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, for consistency, let's hold off on adding Ubuntu 24 in this PR, we can add it everywhere as part of testing and rolling out pelias/docker-baseimage#32.

It's much much easier to do Node.js and Ubuntu version upgrades if our github actions files are consistent. Updating them all en masse can be easily done with scripting if they're identical, but then every difference creates extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants