rewrite node encoding for clarity and ease of extension#97
Open
missinglink wants to merge 1 commit intomasterfrom
Open
rewrite node encoding for clarity and ease of extension#97missinglink wants to merge 1 commit intomasterfrom
missinglink wants to merge 1 commit intomasterfrom
Conversation
ade3605 to
dc26fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR rewrites some older code in a clearer way, which opens it up for extension.
in particular issue #96 could benefit from this refactor
some notes on what this part of the code does:
[]byte{}IEEE 754 binary representationand truncate them to 6 bytes each, which is a nice tradeoff of precision vs. size (this consumes 12 bytes total)the subject of this PR is mainly to make the operations on the metadata byte more obvious and open them up for extension.
I didn't add new tests since https://github.com/pelias/pbf2json/blob/master/encoding_test.go seems to cover this sufficiently
Hey @paulmach if you get a second could you please do a quick review?