Adding new icons to Text Rewriter#17
Open
spade1345 wants to merge 4 commits into
Open
Conversation
Last commit by me had new icons (icon_2) and I added support.
Owner
|
thanks for your contribution! I will test it out in Chrome and Firefox and then merge |
pelmers
reviewed
Mar 16, 2024
Author
|
Also, I'm thinking about modifying it so that instead of using the bade icon to disable replacement on a website the badge opens a popup with the settings menu and a new "Add current domain" button. |
Owner
|
sure, that might be a lot of work, but I'm happy to review such a change. the current behavior where clicking adds the domain to the block list is not that intuitive, you have to read the description to find out what it's doing |
Author
|
Should be simple, commenting out the badge click program, and linking the options page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello pelmers,

I saw that the icons for Text Rewriter are outdated so I made new ones and linked them in manifest.json.