Skip to content

Adding new icons to Text Rewriter#17

Open
spade1345 wants to merge 4 commits into
pelmers:masterfrom
spade1345:master
Open

Adding new icons to Text Rewriter#17
spade1345 wants to merge 4 commits into
pelmers:masterfrom
spade1345:master

Conversation

@spade1345

Copy link
Copy Markdown

Hello pelmers,
I saw that the icons for Text Rewriter are outdated so I made new ones and linked them in manifest.json.
icon2_64

@pelmers

pelmers commented Mar 16, 2024

Copy link
Copy Markdown
Owner

thanks for your contribution! I will test it out in Chrome and Firefox and then merge

Comment thread lib/main.js
@spade1345

Copy link
Copy Markdown
Author

Also, I'm thinking about modifying it so that instead of using the bade icon to disable replacement on a website the badge opens a popup with the settings menu and a new "Add current domain" button.

@pelmers

pelmers commented Mar 18, 2024

Copy link
Copy Markdown
Owner

sure, that might be a lot of work, but I'm happy to review such a change. the current behavior where clicking adds the domain to the block list is not that intuitive, you have to read the description to find out what it's doing

@spade1345

spade1345 commented Mar 18, 2024

Copy link
Copy Markdown
Author

Should be simple, commenting out the badge click program, and linking the options page.
But the issue is the "Add current domain" button.
PS Can you also merge the commits? I'll do the popup on a fresh pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants