logging cleanup#40
Merged
Merged
Conversation
KarlK90
previously approved these changes
Jun 16, 2026
It may be empty, so the message can be confusing without the quotes. Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
With that, the messages are visible with the default CONFIG_CONSOLE_LOGLEVEL_DEFAULT=7. Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Move activating the logger into the logger code. Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
KarlK90
requested changes
Jun 16, 2026
Comment on lines
+181
to
+184
| info!( | ||
| concat!(env!("CARGO_PKG_NAME"), " version {}"), | ||
| git_version!(fallback = env!("CARGO_PKG_VERSION")) | ||
| ); |
Member
There was a problem hiding this comment.
Suggested change
| info!( | |
| concat!(env!("CARGO_PKG_NAME"), " version {}"), | |
| git_version!(fallback = env!("CARGO_PKG_VERSION")) | |
| ); | |
| info!( | |
| "{} version {}", | |
| env!("CARGO_PKG_NAME"), | |
| git_version!(fallback = env!("CARGO_PKG_VERSION")) | |
| ); |
Member
Author
There was a problem hiding this comment.
I'd rather not do that.
- It adds extra overhead at runtime instead of combining the string literals at compile time
- The concat makes it clearer which parts are evaluated at runtime and which at compile time
KarlK90
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor logging improvements, including the refactoring mentioned here #38 (comment).