rm custody service #2229
Open
rm custody service #2229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5c96708 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
validation in service, logic in context is a good seperation of concerns here |
turbocrime
force-pushed
the
custody-service-context
branch
8 times, most recently
from
82b0848 to
16a68a5
Compare
Collaborator
Author
|
implemented more validation and extensive tests of validation. prepares custody service to support more varied implementations |
turbocrime
commented
Apr 25, 2025
turbocrime
commented
Apr 25, 2025
packages/services/src/custody-service/util/validate-response.ts
Outdated
Show resolved
Hide resolved
turbocrime
force-pushed
the
custody-service-context
branch
from
5f283a4 to
f8f3b43
Compare
turbocrime
force-pushed
the
custody-service-context
branch
3 times, most recently
from
3996532 to
630852e
Compare
turbocrime
force-pushed
the
custody-service-context
branch
from
630852e to
5c96708
Compare
TalDerei
approved these changes
May 16, 2025
Contributor
|
this is also good to land after the prax ledger changes merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custody service implementation
focuses on validation. actual authorization logic is provided via context, so service host can be more flexible in implementation.is removed