Merged
Conversation
Deploying pephub-ui with
|
| Latest commit: |
8436347
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0429841.pephub.pages.dev |
| Branch Preview URL: | https://dev.pephub.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds hybrid search functionality combining dense, sparse, and exact match retrieval methods to improve search quality in PEPHub. The implementation uses Qdrant's reciprocal rank fusion (RRF) to blend results from multiple search strategies.
Key changes:
- Added sparse search capability using SPLADE encoder alongside existing dense embeddings
- Implemented hybrid query strategy with prefetch and fusion for improved search relevance
- Removed configurable collection_name parameter, now hardcoded to default
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pephub/routers/models.py | Removed collection_name field from SearchQuery model |
| pephub/routers/api/v1/search.py | Implemented hybrid search with dense, sparse, and exact match retrieval using RRF fusion |
| pephub/dependencies.py | Added sparse encoder model initialization and dependency injection function |
| pephub/const.py | Updated model constants, replacing DEFAULT_HF_MODEL with separate dense and sparse encoder models |
| pephub/_version.py | Bumped version from 0.15.4 to 0.15.5 |
Comments suppressed due to low confidence (3)
pephub/routers/api/v1/search.py:48
- The parameter name "model_sparce" contains a spelling error. It should be "model_sparse" (with an 's' instead of 'c').
return agent.namespace.get(limit=limit, query=query or "", offset=offset)
pephub/routers/api/v1/search.py:68
- The variable "model_sparce" contains a spelling error. It should be "model_sparse" (with an 's' instead of 'c').
pephub/routers/api/v1/search.py:69 - The variable "model_sparce" contains a spelling error. It should be "model_sparse" (with an 's' instead of 'c').
# get namespaces:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
TODO:
__version__.pyfile