PG-1257 Add function for principal key removal #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
2 times, most recently
from
2849a87 to
179f5d7
Compare
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
1392bd7 to
5f91c64
Compare
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
5f91c64 to
369410e
Compare
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
369410e to
a18fe38
Compare
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
a18fe38 to
bd88553
Compare
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
4c1a316 to
4553814
Compare
artemgavrilov
requested review from
nastena1606,
Andriciuc,
dutow and
dAdAbird
as code owners
nastena1606
reviewed
May 29, 2025
dAdAbird
reviewed
May 30, 2025
jeltz
requested changes
May 30, 2025
| PG_RETURN_VOID(); | ||
| } | ||
|
|
||
| pg_tde_delete_principal_key(MyDatabaseId, true); |
There was a problem hiding this comment.
Does it make sense that we delete the copy of the principal key from the database here? Probably but hmm ...
There was a problem hiding this comment.
I'm not sure that I understood what confused you
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
c9b98c3 to
fabd2d0
Compare
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
fabd2d0 to
8575783
Compare
jeltz
requested changes
Jun 9, 2025
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
8575783 to
44065d4
Compare
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
44065d4 to
e02fd51
Compare
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
2 times, most recently
from
30181c6 to
dd71c27
Compare
Andriciuc
approved these changes
Jun 10, 2025
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
dd71c27 to
72d5fce
Compare
dAdAbird
approved these changes
Jun 10, 2025
Add SQL functions that allow user to remove principal key. * Database level principal key can be removed if there are no encrypted tables or if there is default key. For the first case we just drop key map file completely, for the second we perform key rotation. * Default principal key can be removed if there are no databases that use it. Readded the DELETE key function to docs based on 1257 in Architecture chapter where we also update from DROP to DELETE.
artemgavrilov
force-pushed
the
PG-1257-principal-key-remove-feature
branch
from
72d5fce to
5df6c58
Compare
nastena1606
temporarily deployed
to
PG-1257-principal-key-remove-feature - pg-tde-docs PR #374
Render
Destroyed
nastena1606
temporarily deployed
to
PG-1257-principal-key-remove-feature - INTERNAL-pg_tde docs PR #374
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PG-1257
Add SQL functions that allow user to remove principal key.