Create a devcontainer setup#1037
Merged
Merged
Conversation
Collaborator
|
Seems good to me, I would rebase (test should pass when the PR moving to only JRuby10 is merged) and move to Ruby 3.4, but other than that, this makes sense in terms of reducing any pain points on getting up and running with passing tests for contributors and simplifying automation. |
danmayer
approved these changes
May 16, 2025
Collaborator
danmayer
left a comment
danmayer
left a comment
There was a problem hiding this comment.
this looks good to me, thoughts @petergoldstein
petergoldstein
requested changes
May 16, 2025
Owner
petergoldstein
left a comment
petergoldstein
left a comment
There was a problem hiding this comment.
Looks good, but needs a rebase and should be updated to Ruby 3.4. Once that's done, we should merge
PatrickTulskie
force-pushed
the
devcontainer
branch
from
f4a4af7 to
a135ddd
Compare
Contributor
Author
|
@petergoldstein updated with the latest main, upgraded it to Ruby 3.4, and also set the default shell to bash so it's a little more user friendly. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
When I was working on #1036 I needed a clean environment to work from. Since a lot of people use VS Code these days, I setup a devcontainer. I figured I'd share to save others time.
Change Details
This borrows from the setup that is done in the GHA for running the tests. It should let a contributor get up and running pretty quickly and easily regardless of what system they are developing on.