Skip to content

Conversation

nzw0301
Copy link

@nzw0301 nzw0301 commented Mar 21, 2024

I'm not sure this is intended, but the currently we cannot specify out_dir from the argument because self.out_dir is always used.

@nzw0301 nzw0301 force-pushed the use-argument-outdir branch from 3acba47 to df2e83e Compare March 21, 2024 07:17
@linshokaku
Copy link
Member

We have considered revisions in #735, however, either of the following is required:

  • A change in the behavior that is non-obvious to users
  • Breaking backwards compatibility
    • We believe there may be implications for users who utilize subclasses inheriting the Writer class.

Therefore, while the implementation can lead to misunderstandings, we concluded that it does not amount to a critical issue.

@nzw0301 nzw0301 closed this Aug 5, 2024
@kmaehashi kmaehashi added this to the Closed PRs milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants