docs: add basic starter contributing guide#10093
Conversation
Add a CONTRIBUTING.md file to document the contribution workflow for pgAdmin 4. Includes: - Getting started instructions - Issue reporting guidelines - Development workflow and coding practices - Pull request requirements - Development environment setup - Database migration guidance - Security reporting process - Community support resources This provides a single reference for new and existing contributors.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new ChangesContributing Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 91-95: Add a language tag to the Windows command code block in
CONTRIBUTING.md. The fenced code block containing the Windows commands (cd, yarn
install, yarn run bundle) currently lacks a language identifier on the opening
triple-backtick fence. Add `bat` or `powershell` as the language tag immediately
after the opening fence (e.g., ```bat) to satisfy markdownlint requirements and
enable proper syntax highlighting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8e4fc867-506e-42cf-a2c8-401d3cb66187
📒 Files selected for processing (1)
CONTRIBUTING.md
|
I have tried to keep the document as unopinionated as possible and avoided adding my own preferences. That said, a few things may be worth considering: PR namingSome examples of PR naming styles can help maintain cleanliness and clarity in PR naming. Examples:
AI usageWith AI tools becoming common, a short policy may be useful:
These are some of my opinionated suggestions, so let me know if we can include any of this in the new document, and if you guys have any more suggestions, happy to make changes, @asheshv and @dpage. |
|
Thanks for putting this together, @dev-hari-prasad, and for the thoughtful questions. Having reviewed it alongside the existing docs, I'd like to suggest a change of direction before we take it further. The overlap with the README Most of the development-setup content here (Architecture, Prerequisites, Building the Web Assets, Python Environment, Building docs/packages, Database Migrations, Security Issues) is reproduced almost verbatim from the top-level Suggested structure Rather than add a third copy, I think the better shape, and one that genuinely improves things, is:
That keeps each piece of information in exactly one place, with everything else linking to it. It does mean this change grows to include trimming the README, so do shout if you'd like a hand with that part. Two fixes worth noting regardless of structure
On your two questions
Thanks again; this is a useful addition and worth getting the structure right. |
|
Thanks for the detailed feedback. Just to make sure we're on the same page before I start making changes:
If there's anything else you think we can adjust while I'm in there, feel free to shoot it my way. Also, it would be a good idea to tag other core contributors along the way for their input, since these changes affect important documents. |
Clarify contributor workflow, fix the runtime link, and add references to existing contributor docs.
Add a CONTRIBUTING.md file to document the contribution workflow for pgAdmin.
Covers:
It is a single reference for making contributions.
Addresses and closes #10056
Summary by CodeRabbit
Summary by CodeRabbit