Ensure worspaces/pgadmin state is saved on abrupt shutdown of pgadmin.#GH_3319 #8671
Conversation
yogeshmahajan-1903
force-pushed
the
GH_3319
branch
5 times, most recently
from
ae9bd5f to
7441c9e
Compare
yogeshmahajan-1903
force-pushed
the
GH_3319
branch
6 times, most recently
from
72d6539 to
c2980a1
Compare
yogeshmahajan-1903
force-pushed
the
GH_3319
branch
from
c2980a1 to
2b23a35
Compare
There was a problem hiding this comment.
GUI Review Comments:
-
When opening pgAdmin again in the browser Default Workspace should be in focus. Open Schema Diff tool and refresh the browser.
-
PSQL tools database name not showing in the single line on reopening pgAdmin.
-
Delete all the states from the table if the user changes the preferences and sets them to False.
-
Getting error AttributeError: 'NoneType' object has no attribute 'connection' in line 604, in _get_database_role psql/init.py
-
params['db'] = underscore_escape(data['db_name']) TypeError: 'NoneType' object is not subscriptable in line 104 in psql/init.py
-
Open Query Tool/PSQL in the respective workspace and then refresh the browser. It opens in the Default workspace, which seems to be correct, but we need to document this behaviour.
-
Query Tool/PSQL for adHoc servers are still opening with error. We should not store state of the adHoc server.
-
The show_query_tool.js, show_erd_tool.js, showSchemaDiffTool.js and show_psql_tool.js files have duplicate code to open the respective tools. We can easily make some part of the logic generic.
-
Why file name 'showSchemaDiffTool.js' different in respect to others like show_query_tool.js
-
Documentation/Screenshot updates are missing for Preferences.
-
Create a new .rst file to explain this new feature.
-
Add comments in the new function added in this PR and wherever needed in the code, so that others can understand the logic.
| @@ -0,0 +1,33 @@ | |||
|
|
|||
There was a problem hiding this comment.
Add a copyright header in the file.
| @@ -392,6 +392,17 @@ class QueryHistoryModel(db.Model): | |||
| last_updated_flag = db.Column(db.String(), nullable=False) | |||
|
|
|||
|
|
|||
| class PgadminStateData(db.Model): | |||
There was a problem hiding this comment.
Rename this class based on the table name you decide (as per the above review comments).
| @@ -392,6 +392,17 @@ class QueryHistoryModel(db.Model): | |||
| last_updated_flag = db.Column(db.String(), nullable=False) | |||
|
|
|||
|
|
|||
| class PgadminStateData(db.Model): | |||
| """Define the history SQL table.""" | |||
|
|
||
| def upgrade(): | ||
| op.create_table( | ||
| 'pgadmin_state_data', |
There was a problem hiding this comment.
We haven't started any of the tables with pgadmin. Rename this table to any name of your choice:
- 'application_state'
- 'app_state'
- 'workspace_state'
Or any other name that you can think of.
|
|
||
| data = _get_database_role(params['sid'], params['did']) | ||
| print(data) |
There was a problem hiding this comment.
Remove this print statement.
| 'public') | ||
| self.assertTrue(self.page.expand_tables_node( | ||
| "Server", self.server['name'], self.server['db_password'], | ||
| self.test_db,'public'), 'Table node nmot exoanded') |
There was a problem hiding this comment.
Change the message to 'Tree not expanded to the table node.'
| self.database_name, 'public') | ||
| self.assertTrue(self.page.expand_tables_node( | ||
| "Server", self.server['name'], self.server['db_password'], | ||
| self.database_name, 'public'),'Table dialog not opend') |
There was a problem hiding this comment.
Change the message to 'Tree not expanded to the table node.'
| 'public') | ||
| self.assertTrue(self.page.expand_tables_node( | ||
| "Server", self.server['name'], self.server['db_password'], | ||
| self.test_db, 'public'),'Tree not expanded to table') |
There was a problem hiding this comment.
Change the message to 'Tree not expanded to the table node.'
| 'public') | ||
| self.assertTrue(self.page.expand_tables_node( | ||
| "Server", self.server['name'], self.server['db_password'], | ||
| self.test_db, 'public'),'Table node not expanded') |
There was a problem hiding this comment.
Change the message to 'Tree not expanded to the table node.'
| 'public') | ||
| self.assertTrue(self.page.expand_tables_node( | ||
| "Server", self.server['name'],self.server['db_password'], | ||
| self.test_db, 'public'), 'Table node not expanded') |
There was a problem hiding this comment.
Change the message to 'Tree not expanded to the table node.'
No description provided.