Skip to content

Handle GitHub releases with multiple signatures #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle GitHub releases with multiple signatures #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/shared/repository/GithubRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function getReleasesByRequestedPhar(RequestedPhar $requestedPhar): Releas
continue;
}
$pharUrl = null;
$signatureUrl = null;
$signatureUrl = [];

foreach ($entry['assets'] as $asset) {
$url = $asset['browser_download_url'];
Expand All @@ -48,7 +48,7 @@ public function getReleasesByRequestedPhar(RequestedPhar $requestedPhar): Releas
}

if (in_array(substr($url, -4, 4), ['.asc', '.sig'], true)) {
$signatureUrl = new Url($url);
$signatureUrl[$url] = new Url($url);
}
}

Expand All @@ -61,6 +61,12 @@ public function getReleasesByRequestedPhar(RequestedPhar $requestedPhar): Releas
continue;
}

// if the release has multiple signatures, use the one that's closest to the
// name of the phar, e.g. doctum.phar.asc instead of doctum.phar.sha256.asc
$signatureUrl = $signatureUrl[$pharUrl . '.asc']
?? $signatureUrl[$pharUrl . '.sig']
?? array_shift($signatureUrl);

// we do have a phar but no signature, could potentially be used
if (!$signatureUrl instanceof Url) {
$releases->add(
Expand Down