Skip to content

Reduced UIManager api #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: Pharo13
Choose a base branch
from
+2 −2
Open

Reduced UIManager api #1751

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
968faea
Reduced UIManager api
AlexisCnockaert Mar 28, 2025
4328057
Replaced Morphic call by a SpInformDialog presenter
AlexisCnockaert Mar 28, 2025
53e806b
Use spec application instead because we cant deal with headless image…
AlexisCnockaert Mar 28, 2025
53a7b10
Merge branch 'pharo-spec:Pharo13' into Pharo13
AlexisCnockaert Apr 25, 2025
26b1c78
Merge branch 'pharo-spec:Pharo13' into Pharo13
AlexisCnockaert May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Spec2-Commander2/SpInvalidUserInputError.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ Extension { #name : 'SpInvalidUserInputError' }
{ #category : '*Spec2-Commander2' }
SpInvalidUserInputError >> actForSpec [
"Does nothing on purpose."
UIManager default
inform: self messageText.

GrowlMorph new
Copy link
Collaborator

@demarey demarey Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot reference Morphic directly here.
It should be usable in Gtk also

Copy link
Contributor

@Ducasse Ducasse Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!
@AlexisCnockaert

Copy link
Contributor

@Ducasse Ducasse Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a SpDialog

Copy link
Contributor Author

@AlexisCnockaert AlexisCnockaert Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok nevermind ill do this

contents: self messageText;
openInWorld.
self flag: #TODO "In the best world, we should delegate the behaviour to the Spec presenter which originated the error."
]
Loading